Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to whisper.cpp v1.3.0. #33

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Update to whisper.cpp v1.3.0. #33

merged 6 commits into from
Apr 18, 2023

Conversation

tazz4843
Copy link
Owner

This PR includes major breaking changes! Check out the CHANGELOG.md file for more information on the changes, and provide feedback after merge here as well.

@tazz4843
Copy link
Owner Author

Closes #28 and #29

This was linked to issues Apr 18, 2023
Does have a way to load the model only once and use it for multi audio file in the same time? #28
Closed
whisper-rs-sys published to crates.io is out-of-date #29
Closed
@tazz4843
Copy link
Owner Author

Hmm this PR seems to have triggered some issues on my system (Arch Linux, kernel 6.2.11-arch1-1)

  --- stderr
  CMake Error: File /home/zero/data/CLionProjects/whisper-rs/target/package/whisper-rs-sys-0.4.0/whisper.cpp/bindings/javascript/package-tmpl.json does not exist.
  CMake Error at CMakeLists.txt:23 (configure_file):
    configure_file Problem configuring file


  CMake Error at CMakeLists.txt:298 (add_subdirectory):
    add_subdirectory given source "bindings" which is not an existing
    directory.


  thread 'main' panicked at 'Failed to generate build script', build.rs:77:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@tazz4843
Copy link
Owner Author

Ah I believe this is the exclude directive in the Cargo.toml excluding the bindings. I'll see how little I can get away with, as I don't want to bloat the size.

@tazz4843 tazz4843 merged commit 3e5d0f3 into master Apr 18, 2023
@tazz4843 tazz4843 deleted the whisper-cpp-v1.3.0 branch April 18, 2023 00:37
@delta62
Copy link

delta62 commented May 10, 2023

I have problems using this version as it looks like create_state() isn't publicly visible (maybe #41?)

@tazz4843
Copy link
Owner Author

Oops, I thought I published a new version at some point. I'll do so in an hour or so. Thanks for pointing it out.

@tazz4843
Copy link
Owner Author

Forgot to mention this, but I published v0.7.0 last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tazz4843 @delta62